Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5400 revert f view #5407

Merged
merged 2 commits into from
Dec 18, 2018
Merged

5400 revert f view #5407

merged 2 commits into from
Dec 18, 2018

Conversation

mheppler
Copy link
Contributor

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.665% when pulling cbc7dd6 on 5400-revert-f-view into 4fcbc4b on develop.

@pdurbin pdurbin mentioned this pull request Dec 17, 2018
Closed
@pameyer pameyer mentioned this pull request Dec 17, 2018
Closed
matthew-a-dunlap
matthew-a-dunlap approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@matthew-a-dunlap matthew-a-dunlap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Its cool to finally try out the internationalization, great work.

@mheppler mheppler mentioned this pull request Dec 18, 2018
Closed
@kcondon kcondon merged commit a6bd81c into develop Dec 18, 2018
@kcondon kcondon deleted the 5400-revert-f-view branch December 18, 2018 20:52
@pdurbin pdurbin mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-a-dunlap matthew-a-dunlap matthew-a-dunlap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.10 - Additional Data Transfer Options
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mheppler @coveralls @matthew-a-dunlap @pdurbin @kcondon